Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

docs(pipes): add safari compatibility #1572

Closed
wants to merge 1 commit into from

Conversation

Foxandxss
Copy link
Member

The plunker in safari was broken because it needs that concrete polyfill.

You can read more at angular/angular#3333 (comment)

@wardbell
Copy link
Contributor

wardbell commented Jun 4, 2016

This is incomplete in several respects

  • Let's keep shims together. The new polyfil should be moved up near (just below?) the other browser shim. If it must be where it is, explain why.
  • We can't get this from npm? Why. We strive to have development work entirely offline w/o any 404s.
  • If we can install with npm, must update plunker tool to map back to the web (using npmcdn preferably).
  • Explain why this shim is needed in this example and not everywhere. If only here, must update the chapter so that the reader knows to add this shim.
  • If should add this shim everywhere, then explain in the Quickstart and add to all index.html.
  • If should add this shim everywhere, reconcile with the CLI's position on shims (I don't know what that is).

Sorry, I know this is a royal PITA. But just slapping a shim into the example is not the answer.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants